refactor: return 204 No Content from UserTimezoneController update method #775
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR refactors the
UserTimezoneController::updatemethod to return an explicit204 No Contentresponse instead of relying on Laravel's defaultvoidresponse behavior.Changes Made
voidtoIlluminate\Http\Responseresponse()->noContent()after successfully updating the session timezoneRationale
Impact
There is no change in functionality, but the API behavior is now more explicit. This is a safe and non-breaking change.
Testing
Manually tested via the front-end call and verified that:
204 No Content