Skip to content

A Procedural Solution #4

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
plainprogrammer wants to merge 22 commits into
base: main
Choose a base branch
from
Draft

A Procedural Solution #4

plainprogrammer wants to merge 22 commits into from

Conversation

@plainprogrammer
Copy link
Owner

@plainprogrammer plainprogrammer commented Oct 27, 2021 •
edited
Loading

This solution follows a simple procedural approach that results in update methods for each of the item types in the Gilded Rose building on top of more fundamental increment and decrement methods for quality and sell-in.

@plainprogrammer
Flatten first conditional block to clarify what item type is in scope.
b2422b2
@plainprogrammer
Replace negative condition with positive condition to reveal what ite…
82d71d3 
…m type we are checking in first conditional.
@plainprogrammer
Convert second top-level condition to unless for clarity of check.
7ec8972
@plainprogrammer
Reverse conditional structure to state positive case for backstage pa…
262663d 
…ss item type in third conditional block.
@plainprogrammer
Pulled nested conditional to higher level to reduce nesting in third …
3548bed 
…conditional section.
@plainprogrammer
Inlined all quality guard clauses to further flatten conditionals.
5a4aa41
@plainprogrammer
Extract decrement quality method to reduce duplication.
5fc9d48
@plainprogrammer
Extract increment quality method to reduce duplication.
27f9b34
@plainprogrammer
Changed first conditional section to a case statement to clarify item…
b4076af 
… type behavior.
@plainprogrammer
Introduce ability to adjust quality increment via argument.
b0e6242
@plainprogrammer
Use ability to specify quality increment amount to clarify how backst…
f98b49c 
…age passes behave.
@plainprogrammer
Flatten nested conditional in third conditional section to clarify it…
93f2801 
…em type behavior.
@plainprogrammer
Change third conditional section to use case to clarify item type beh…
c7e74a2 
…avior.
@plainprogrammer
Extracted conditional for expiration detection into method to clarify…
8ff3fb5 
… intent.
@plainprogrammer
Consolidate all item behaviors into singular case statement within up…
a27f6d8 
…date quality method.
@plainprogrammer
Extract item type behaviors into discreet update methods.
d88e08d
@plainprogrammer
Reordered methods to clarify their relationship to each other.
ca13f0b
@plainprogrammer
Changed expiration behavior for updating backstage pass for increased…
5386e02 
… clarity.
@plainprogrammer
Rearranged code for updating aged brie to adjust sell in before adjus…
e2ea8b4 
…ting quality.
@plainprogrammer
Rearranged code for updating backstage passes to adjust sell in befor…
ce0c8f4 
…e adjusting quality.
@plainprogrammer
Rearranged code for updating normal items to adjust sell in before ad…
c95a9aa 
…justing quality.
@plainprogrammer
Add support for the Conjured Mana Cake item.
58de357
@plainprogrammer plainprogrammer changed the title Sample Solution #1 A Procedural Solution Oct 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@plainprogrammer