feat: Add OPA Rego v1 support #665
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mrueg
reviewed
Jan 4, 2026
|
|
||
| // StripV1Imports removes `import future.keywords.*` and `import rego.v1` | ||
| // imports from Rego source code since these are not needed in OPA v1. | ||
| func StripV1Imports(source string) string { |
Contributor
There was a problem hiding this comment.
I get the idea, I personally woudn't want konstraint to alter the rego code though. Could this be put behind an additional command line flag like --strip-v0-imports?
mrueg
reviewed
Jan 4, 2026
| prevBlank := false | ||
| for line := range strings.SplitSeq(source, "\n") { | ||
| trimmed := strings.TrimSpace(line) | ||
| if strings.HasPrefix(trimmed, "import future.keywords") || |
Contributor
There was a problem hiding this comment.
Should we be explicit here and mention all keywords it should filter?
I wonder what happens if rego v1 needs additional keywords and they get added to future.keywords
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
--rego-versionflag tocreateanddoccommands (default: v0)ConstraintTemplatesimport future.keywords.*andimport rego.v1from v1 outputFixes #637 & #663