Skip to content

convert strings with v8::String::Write() #225

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
pmed merged 4 commits into from
Feb 9, 2025
Merged

convert strings with v8::String::Write() #225

pmed merged 4 commits into from
Feb 9, 2025

Conversation

@pmed
Copy link
Owner

@pmed pmed commented Feb 9, 2025

  • for direct writes into the std::string result buffer instead of intermediate v8::String::Utf8Value

pmed added 4 commits February 9, 2025 14:06
@pmed
convert strings with v8::String::Write()
2fa3966 
- for direct writes into the std::string result buffer instead of intermediate `v8::String::Utf8Value`
@pmed
use v8::String::WriteV2() for v8 >= 13.3
d618b72 
... to fix deprecation warnings
@pmed
use v8::ExternalMemoryAccounter for v8 >= 13.3
6b68a4a 
.. instead of deprecated `v8::Isolate::AdjustAmountOfExternalAllocatedMemory()`
@pmed
use v8::Object::GetPrototypeV2() for v8 >= 12.9
f1dbc5b 
... instead of deprecated `GetPrototype()`
@pmed pmed merged commit f08867e into master Feb 9, 2025
24 checks passed
@pmed pmed deleted the newer_v8_api branch February 9, 2025 15:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@pmed