gh-142982 Implement _SEND_NON_GEN specialization #143977
Open
+1,426
−1,081
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alonme
requested review from
Fidget-Spinner,
markshannon,
savannahostrowski and
tomasr8
as code owners
Member
Fidget-Spinner
left a comment
Fidget-Spinner
left a comment
There was a problem hiding this comment.
I'm thinking of whether this is worth it, as we're running low on opcodes now. So I'll leave Mark to review.
Contributor
Author
@Fidget-Spinner - does the same apply to Would it make sense to run benchmarks to measure the effect of this change, to better inform the decision? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a generic specialization for SEND for non generator and Coro cases
@Fidget-Spinner @markshannon
How can i run the Pystats and benchmark suites?