Skip to content

Fix missing includes for C++23 #16208

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jgibson2 wants to merge 2 commits into
base: main
Choose a base branch
from
+5 −1
Open

Fix missing includes for C++23 #16208

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0a20c19
Fix missing includes for C++23
jgibson2 Dec 11, 2025
ea7315a
Update backends/apple/coreml/runtime/kvstore/key_value_store.hpp
jgibson2 Dec 11, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions backends/apple/coreml/runtime/delegate/ETCoreMLAsset.mm
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@
#import "objc_safe_cast.h"

#import <fcntl.h>
#import <memory>
Copy link

Copilot AI Dec 11, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

C++ standard library headers should use #include instead of #import. The #import directive is specific to Objective-C, while #include is the standard C++ directive. Change to #include <memory> for correctness.

Suggested change
#import <memory>
#include <memory>

Copilot uses AI. Check for mistakes.
Copy link
Contributor

@cccclai cccclai Dec 11, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems like a reasonable review

Copy link
Contributor Author

@jgibson2 jgibson2 Dec 11, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should I change all of these? A lot of the others are C++ libs that are #imported as well

Copy link
Contributor

@cccclai cccclai Dec 11, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@shoumikhin @metascroy what do you think?

Copy link
Contributor Author

@jgibson2 jgibson2 Dec 15, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any updates on this?

Copy link
Contributor

@cccclai cccclai Dec 15, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Adding @metascroy for reviewing

#import <os/lock.h>
#import <stdio.h>
#import <system_error>
Expand Down
1 change: 1 addition & 0 deletions backends/apple/coreml/runtime/delegate/multiarray.mm
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@
#import "objc_array_util.h"

#import <Accelerate/Accelerate.h>
#import <algorithm>
Copy link

Copilot AI Dec 11, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

C++ standard library headers should use #include instead of #import. While this may work in practice, #import is an Objective-C directive and #include is the correct directive for C++ standard headers. Change to #include <algorithm> for correctness.

Suggested change
#import <algorithm>
#include <algorithm>

Copilot uses AI. Check for mistakes.
#import <CoreML/CoreML.h>
#import <functional>
#import <numeric>
Expand Down
3 changes: 2 additions & 1 deletion backends/apple/coreml/runtime/kvstore/key_value_store.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,8 @@

#pragma once

#import <functional>
#include <atomic>
#include <functional>
#include <optional>
#include <memory>
#include <string>
Expand Down
1 change: 1 addition & 0 deletions backends/apple/coreml/runtime/kvstore/statement.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@

#pragma once

#include <memory>
#include <string>
#include <system_error>
#include <sqlite3.h>
Expand Down
Loading