Skip to content

Conversation

@hdonnay
Copy link
Member

@hdonnay hdonnay commented Jan 6, 2026

PoC for a possible use of the toolkit/events package.

The idea is that for every piece of code that we want to emit an "event" in a "debug request" it does something like this:

  • Emit 1 event
  • Collect metrics-like pre-definied pieces of information.
  • Flag an error return with an error "level" event.

Questions:

  • Do other log levels make sense?
  • How many events is too many?

Review on CodeApprove

Signed-off-by: Hank Donnay <hdonnay@redhat.com>
Signed-off-by: Hank Donnay <hdonnay@redhat.com>
@hdonnay hdonnay added the experiment For pull requests that are experimental. label Jan 6, 2026
@hdonnay
Copy link
Member Author

hdonnay commented Jan 6, 2026

I'm inclined to try the "wide log" style for these events. But does one want to actually see every rejected vulnerability and why? Or is that a log handler's problem?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

codeapprove experiment For pull requests that are experimental.

Development

Successfully merging this pull request may close these issues.

1 participant