-
Notifications
You must be signed in to change notification settings - Fork 1
70 metabolomics data #71
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Conversation
jgriss
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
While this PR contains the required changes in the API "frontend", the support in the analysis code is still missing.
|
@jgriss How is the analysis code affected? |
EliotRagueneau
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good to me, but Johannes will know better if something is missing
| description="Single-cell RNA-seq data of B cells extracted from the Jerby-Arnon at al. study (Cell 2018).", | ||
| group="SC_EXAMPLES"), | ||
| ExternalData(id="EXAMPLE_METABOLOMICS", title="Liver cirrhosis metabolomics example", type="metabolomics", | ||
| description="MTBLS5665: Transcriptomic and metabolomic analysis of liver cirrhosis", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe it would be better to not start the description with the identifier. It should follow the same structure as other example definitions in my opinion. (Not a bad idea to add the dientifier though, but maybe more at the end, it's more inviting to read)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
|
About the analysis code:
|
|
One additional important note: Need to check whether this requires different internal mapping files (currently UniProt and ENSEMBL are directly supported) |
No description provided.