Skip to content

Conversation

@alexgrent
Copy link
Collaborator

No description provided.

@alexgrent alexgrent self-assigned this Aug 19, 2024
Copy link
Collaborator

@jgriss jgriss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While this PR contains the required changes in the API "frontend", the support in the analysis code is still missing.

@alexgrent
Copy link
Collaborator Author

alexgrent commented Aug 29, 2024

@jgriss How is the analysis code affected?
Do you mean the swagger models used? If yes updated with the last commit.

Copy link

@EliotRagueneau EliotRagueneau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good to me, but Johannes will know better if something is missing

description="Single-cell RNA-seq data of B cells extracted from the Jerby-Arnon at al. study (Cell 2018).",
group="SC_EXAMPLES"),
ExternalData(id="EXAMPLE_METABOLOMICS", title="Liver cirrhosis metabolomics example", type="metabolomics",
description="MTBLS5665: Transcriptomic and metabolomic analysis of liver cirrhosis",

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe it would be better to not start the description with the identifier. It should follow the same structure as other example definitions in my opinion. (Not a bad idea to add the dientifier though, but maybe more at the end, it's more inviting to read)

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

@alexgrent
Copy link
Collaborator Author

About the analysis code:

  • Metabolomics data is mainly generated by Mass spec which we can already handle as a data format.
    In some cases NMR spectroscopy is used this is only a minority (181 out of 1611 in the Metabolights database)
  • In general Pathway analysis using ORA algorithms such as PADOG and CAMERA is possible and we would be able to integrate it in our existing workflow
  • Still it is not possible to use Mass spec metabolomics datasets in reactomeGSA with our existing algorithms.
    -> not enough Metabolomic KEGG identifier are represented in Reactome

@jgriss
Copy link
Collaborator

jgriss commented Sep 28, 2024

One additional important note: Need to check whether this requires different internal mapping files (currently UniProt and ENSEMBL are directly supported)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants