fix: prevent fetcher formData race condition in optimistic UI (#14506)

[SarthakRawat-1]

Description

Fixes a race condition where fetcher.formData becomes undefined before navigation loaderData is available, causing UI flicker in optimistic update patterns.

Problem

The issue occurred because fetchers transitioned to idle state in processLoaderData before the navigation's loaderData was committed in completeNavigation. This created a gap where both formData and updated loaderData were unavailable, causing the UI to briefly show stale data.

Solution

• Keep fetchers in loading state with formData preserved until navigation completes
• Transition fetchers to idle atomically with loaderData updates in completeNavigation
• Ensures no gap where optimistic UI falls back to stale data

Changes

• Modified processLoaderData to preserve fetcher loading state during navigation
• Updated completeNavigation to handle fetcher state transitions atomically

Testing

• UI shows true -> true -> true (no flicker). Previously would have shown true -> false -> true (flicker)
• Test passes with the fix applied

Fixes #14506

[changeset-bot]

🦋 Changeset detected

Latest commit: 63407e1

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 11 packages

Name	Type
react-router	Patch
@react-router/architect	Patch
@react-router/cloudflare	Patch
@react-router/dev	Patch
react-router-dom	Patch
@react-router/express	Patch
@react-router/node	Patch
@react-router/serve	Patch
@react-router/fs-routes	Patch
@react-router/remix-routes-option-adapter	Patch
create-react-router	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

[remix-cla-bot]

Hi @SarthakRawat-1,

Welcome, and thank you for contributing to React Router!

Before we consider your pull request, we ask that you sign our Contributor License Agreement (CLA). We require this only once.

You may review the CLA and sign it by adding your name to contributors.yml.

Once the CLA is signed, the CLA Signed label will be added to the pull request.

If you have already signed the CLA and received this response in error, or if you have any questions, please contact us at hello@remix.run.

Thanks!

- The Remix team

[remix-cla-bot]

Thank you for signing the Contributor License Agreement. Let's get this merged! 🥳

[brophdawg11]

Would you mind adding a changeset and seeing if you can add a unit test to demonstrate the buggy behavior?

[SarthakRawat-1]

Added both of them. It's the same test that I did before as well but I removed unnecessary logging in console logs.