Skip to content

fixed #693 #694

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
antoniosanct wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fixed #693 #694

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions rome-modules/src/main/java/com/rometools/modules/itunes/io/ITunesGenerator.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -90,7 +90,7 @@ public void generate(final Module module, final Element element) {
}

if (info.getComplete()) {
element.addContent(generateSimpleElement("complete", "yes"));
element.addContent(generateSimpleElement("complete", "Yes"));
}

if (info.getNewFeedUrl() != null) {
Expand All @@ -104,7 +104,7 @@ public void generate(final Module module, final Element element) {
element.addContent(generateSimpleElement("duration", info.getDuration().toString()));
}
if (info.getClosedCaptioned()) {
element.addContent(generateSimpleElement("isClosedCaptioned", "yes"));
element.addContent(generateSimpleElement("isClosedCaptioned", "Yes"));
}
if (info.getOrder() != null) {
element.addContent(generateSimpleElement("order", info.getOrder().toString()));
Expand Down Expand Up @@ -133,9 +133,9 @@ public void generate(final Module module, final Element element) {

if (itunes.getExplicitNullable() != null) {
if (itunes.getExplicitNullable()) {
element.addContent(generateSimpleElement("explicit", "yes"));
element.addContent(generateSimpleElement("explicit", "true"));
} else {
element.addContent(generateSimpleElement("explicit", "no"));
element.addContent(generateSimpleElement("explicit", "false"));
}
}

Expand Down
6 changes: 3 additions & 3 deletions rome-modules/src/main/java/com/rometools/modules/itunes/io/ITunesParser.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -108,7 +108,7 @@ public com.rometools.rome.feed.module.Module parse(final Element element, final

final Element complete = element.getChild("complete", ns);
if (complete != null) {
feedInfo.setComplete("yes".equals(complete.getTextTrim().toLowerCase()));
feedInfo.setComplete("yes".equalsIgnoreCase(complete.getTextTrim()));
}

final Element newFeedUrl = element.getChild("new-feed-url", ns);
Expand Down Expand Up @@ -140,7 +140,7 @@ public com.rometools.rome.feed.module.Module parse(final Element element, final

final Element closedCaptioned = element.getChild("isClosedCaptioned", ns);

if (closedCaptioned != null && closedCaptioned.getValue() != null && closedCaptioned.getValue().trim().equalsIgnoreCase("yes")) {
if (closedCaptioned != null && closedCaptioned.getValue() != null && "yes".equalsIgnoreCase(closedCaptioned.getValue().trim())) {
entryInfo.setClosedCaptioned(true);
}

Expand Down Expand Up @@ -199,7 +199,7 @@ public com.rometools.rome.feed.module.Module parse(final Element element, final
// Ignore case of the value, assuming that any kind of "yes" clearly shows the intent.
if (block != null
&& block.getValue() != null
&& block.getValue().trim().equalsIgnoreCase("Yes")) {
&& "yes".equalsIgnoreCase(block.getValue().trim())) {
module.setBlock(true);
}

Expand Down