Skip to content

Conversation

@jellydn
Copy link
Contributor

@jellydn jellydn commented Jan 6, 2026

What

This PR adds Dreamcast platform directory mappings for NextUI and Spruce CFWs, which were previously empty and causing Dreamcast ROMs to fail during platform mapping.

Why

Dreamcast ROMs could not be mapped in NextUI and Spruce because the platform mapping arrays were empty ("dc": []) in their configuration files. This broke:

  • Platform directory creation
  • ROM downloads to Dreamcast directories
  • Save synchronization for Dreamcast games

How

Updated the platform mapping configurations with the correct directory names:

NextUI (constants/cfw/nextui/platforms.json):

"dc": ["Sega Dreamcast (DC)"]
  • Follows NextUI's Full Name (TAG) naming convention
  • Matches existing patterns like "Nintendo Entertainment System (FC)"

Spruce (constants/cfw/spruce/platforms.json):

"dc": ["DC"]
  • Follows Spruce's simple uppercase tag convention
  • Matches existing patterns like "ARCADE", "AMIGA", "CPC"

Technical Details

The mapping system uses these arrays to:

  1. Match platform slugs to CFW-specific directory names
  2. Extract tags for NextUI using ParseTag() (regex: \((.*?)\))
  3. Enable proper directory validation and creation

Empty arrays caused RomMSlugToCFW() to return an empty string, breaking directory matching in settings_platform_mapping.go:205-219.

Testing

  • ✅ JSON syntax validated for both files
  • ✅ Follows existing CFW naming conventions
  • ✅ Enables Dreamcast platform mapping UI
  • ✅ Allows ROM directory creation
  • ✅ Supports ROM downloads and save sync

🤖 Generated with Claude Code

Dreamcast ROMs could not be mapped in NextUI and Spruce because the
platform mapping arrays were empty in their configuration files.

Changes:
- NextUI: Added "Sega Dreamcast (DC)" mapping
- Spruce: Added "DC" mapping

This fixes platform directory creation, ROM downloads, and save
synchronization for Dreamcast on both CFWs.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <noreply@anthropic.com>
@pawndev
Copy link
Contributor

pawndev commented Jan 6, 2026

For NextUI, I think it's missing the edit on the save_directories.json to be able to sync save too, no ?

BrandonKowalski added a commit that referenced this pull request Jan 7, 2026
Copy link
Member

@BrandonKowalski BrandonKowalski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@BrandonKowalski BrandonKowalski changed the base branch from main to dev January 7, 2026 00:06
@BrandonKowalski BrandonKowalski changed the base branch from dev to main January 7, 2026 00:07
@BrandonKowalski BrandonKowalski merged commit b67e208 into rommapp:main Jan 7, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants