Prevent starting processes indefinitely. #67
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Close the socket to prevent the system from starting infinite processes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close the socket to prevent the system from starting infinite processes.
We encountered an issue where this function would attempt to open ~15-20 sockets every second without ever closing them.
This was reproduced consistently by simply connecting an iPhone and waiting for the infinite number of processes to eventually reach the maximum limit available on our machine (Macbook pro)
At this point, all apps would cease the function. It was no longer possible to even restart the machine from the menu. A manual power cycle was required.