Pass compatible function pointer type to rb_ensure for GCC 15 #29
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GCC 15 was raising this error:
```
iconv.c:779:42: error: passing argument 3 of ‘rb_ensure’ from incompatible pointer type [-Wincompatible-pointer-type]
779 | return rb_ensure(rb_yield, self, (VALUE(*)())iconv_finish, self);
| ^~~~~~~~~~~~~~~~~~~~~~~~
| |
| VALUE (*)(void) {aka long unsigned int (*)(void)}
In file included from /mise/installs/ruby/3.4.2/include/ruby-3.4.0/ruby/ruby.h:41:
/mise/installs/ruby/3.4.2/include/ruby-3.4.0/ruby/internal/iterator.h:425:62: note: expected ‘VALUE (*)(VALUE)’ {akalong unsigned int (*)(long unsigned int)’} but argument is of type ‘VALUE (*)(void)’ {aka ‘long unsigned int (*)(void’}
425 | VALUE rb_ensure(VALUE (*b_proc)(VALUE), VALUE data1, VALUE (*e_proc)(VALUE), VALUE data2);
| ~~~~~~~~^~~~~~~~~~~~~~
```
Member
|
👍 |
|
Thx for fixing this! Is there an estimate when this is going to be released? @hsbt |
Member
|
That was quick. Thank you very much! :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GCC 15 was raising this error: