Skip to content

Conversation

@sgued
Copy link
Contributor

@sgued sgued commented Dec 30, 2025

Fix #636

Does two things:

  • Add missing ?Sized bounds
  • Make PartialEq's RHS be generic over the storage in deque and history_buf.

@sgued
Copy link
Contributor Author

sgued commented Dec 30, 2025

Blocked by #638

@zeenix
Copy link
Contributor

zeenix commented Dec 31, 2025

Blocked by #638

Just queued that for merging. In the future, just include such trivial fixes to the same PR (just in separate commit). While smaller/atomic PRs are ideal, it's more important to keep commits atomic (so you can revert individual changes later, if needed and it's easier to review, among other benefits).

Copy link
Contributor

@zeenix zeenix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM in general. Thanks for doing this! 👍

@sgued sgued force-pushed the sized-bounds branch 2 times, most recently from 9f3f854 to d507836 Compare December 31, 2025 16:44
@sgued sgued changed the title Fix missing ?Sized bounds for partialeq implementations Relax bounds in PartialEq implementations Dec 31, 2025
@sgued
Copy link
Contributor Author

sgued commented Dec 31, 2025

Blocked by #638

Just queued that for merging. In the future, just include such trivial fixes to the same PR (just in separate commit). While smaller/atomic PRs are ideal, it's more important to keep commits atomic (so you can revert individual changes later, if needed and it's easier to review, among other benefits).

I think it can be useful to separate uncontroversial changes, like clippy lints, from PRs such as this one so that the clippy lints can be merged immediately and not be blocked by review comment on this PR, which could be an annoyance for someone opening another PR while this one is being reviewed.

@zeenix
Copy link
Contributor

zeenix commented Dec 31, 2025

I think it can be useful to separate uncontroversial changes, like clippy lints, from PRs such as this one so that the clippy lints can be merged immediately and not be blocked by review comment on this PR, which could be an annoyance for someone opening another PR while this one is being reviewed.

Oh, I agree completely. I just didn't think of this as a controversial PR as I don't see why anyone would disagree with this. :)

@zeenix zeenix added this pull request to the merge queue Dec 31, 2025
Merged via the queue into main with commit 78eab14 Dec 31, 2025
21 checks passed
@zeenix zeenix deleted the sized-bounds branch December 31, 2025 17:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

?Sized bounds on storage type parameters are inconsistent.

2 participants