-
Notifications
You must be signed in to change notification settings - Fork 235
Relax bounds in PartialEq implementations
#637
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Blocked by #638 |
Just queued that for merging. In the future, just include such trivial fixes to the same PR (just in separate commit). While smaller/atomic PRs are ideal, it's more important to keep commits atomic (so you can revert individual changes later, if needed and it's easier to review, among other benefits). |
zeenix
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM in general. Thanks for doing this! 👍
9f3f854 to
d507836
Compare
PartialEq implementations
I think it can be useful to separate uncontroversial changes, like clippy lints, from PRs such as this one so that the clippy lints can be merged immediately and not be blocked by review comment on this PR, which could be an annoyance for someone opening another PR while this one is being reviewed. |
…` generic over the storage of the RHS
Oh, I agree completely. I just didn't think of this as a controversial PR as I don't see why anyone would disagree with this. :) |
Fix #636
Does two things:
?SizedboundsPartialEq's RHS be generic over the storage indequeandhistory_buf.