Fix bugs with SCIP field enclosing_range #21271
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CatherineGasnier
force-pushed
the
fix-scip-enclosing_range
branch
from
c56b8b1 to
b17b256
Compare
Summary: Test Plan: Reviewers: Subscribers: Tasks: Tags:
CatherineGasnier
force-pushed
the
fix-scip-enclosing_range
branch
from
b17b256 to
7a1b1a0
Compare
rustbot
added
the
S-waiting-on-review
ChayimFriedman2
requested changes
Dec 21, 2025
Contributor
ChayimFriedman2
left a comment
ChayimFriedman2
left a comment
There was a problem hiding this comment.
The old code looks correct to me, the changes here aren't. The culprit is likely isn't here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: Previously, the enclosing range of a function name would be the range of the whole enclosing
impl. I'm not sure exactly why, but the old code for enclosing_range was just not doing the right thing. The new doc comments should make it clear what we're trying to achieve in this new version.Related PR: #21141
Test Plan:
Added unit test.
Also tested on Graphite repo