fix "Run Doctest" lens shows up on compile_fail tests #19103 #21305
Conversation
rustbot
added
the
S-waiting-on-review
There was a problem hiding this comment.
Pull request overview
This PR fixes issue #19103 where "Run Doctest" lens shows up on compile_fail tests. The fix adds tracking of compile_fail attributes in doc test blocks to prevent confusing compiler error output when running doctests with the default --nocapture flag.
Key Changes:
- Added
has_compile_failboolean field toRunnableKind::DocTestto track whether any compile_fail blocks exist in the docstring - Refactored doc test parsing to scan all fenced code blocks and detect compile_fail attributes while maintaining support for edition tags
- Modified cargo command builder to filter out
--nocaptureflag when compile_fail blocks are present
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
crates/ide/src/runnables.rs |
Added has_compile_fail field to RunnableKind::DocTest, refactored has_runnable_doc_test to runnable_doc_test_info with enhanced parsing logic that handles both comma and whitespace-separated attributes, added regression test |
crates/rust-analyzer/src/target_spec.rs |
Made extra_test_binary_args mutable and added logic to filter --nocapture flag for doctests with compile_fail blocks |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
asukaminato0721
force-pushed
the
19103
branch
from
d639195 to
9f34417
Compare
| cargo_args.push("--doc".to_owned()); | ||
| executable_args.push(test_id.to_string()); | ||
| if *has_compile_fail { | ||
| extra_test_binary_args.retain(|arg| arg != "--nocapture"); |
There was a problem hiding this comment.
I don't think this here is a good solution for the issue? At least, reading through it the problem is that vscode recognizes the successful failure as a failure when it shouldn't due to the problem matchers. Unsure how we can make this work though
asukaminato0721
force-pushed
the
19103
branch
from
9f34417 to
7bfa62e
Compare
3 participants
fix #19103
Added a has_compile_fail flag to RunnableKind::DocTest so we remember when a runnable’s docs include compile-fail snippets; the doc parser now scans every fenced block (handling indentation and both comma/whitespace separators) to capture that metadata while still allowing edition tags such as 2024.
When building Cargo commands we drop the default --nocapture argument for doc tests that have compile‑fail snippets, preventing cargo test output from showing expected compiler errors as if the test failed.
Added a regression test that confirms compile‑fail doctests are still exposed as runnables and that the new flag is set.