-
Notifications
You must be signed in to change notification settings - Fork 1.9k
feat: implement configuration to change sub command for test, bench and doctest #21308
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
dc2bb03 to
97e140f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, minus one thing: we generally have X_overrideCommand called for completely overriding the command, and be Option<Vec<String>>, while "X_command": "foo" is a single String and is being integrated in the existing place (cargo foo --args). You can have both are either, but please don't confuse them.
|
Oh should this be then |
|
As I said, we generally have two configs, one |
|
I'm really sorry, I’m having some difficulty understanding what you mean. |
|
Yes. |
|
Oh I see. Thanks. Then I'll make the change for override command to be command and include an arguments config like so: So for example to use nextest those two will be {
"rust-analyzer.runnables.test.command": "nextest",
"rust-analyzer.runnables.test.args": ["run"]
}Similar for bench and doctest as well. |
|
I've pushed the changes as separate commit, so that if this change is fine I'll squash them into one before merging (if that's fine). P.S: I'm sorry for earlier. I had some difficultly understanding what you changed were asked of me. |
ChayimFriedman2
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's not what I suggested. I suggested a pair of fields for each configuration, X_command and X_overrideCommand. No X_args. If this setup does not work for doctests, we cam not provide X_command for it.
|
Ah I see. Ok, then I'll remove doctests and include only bench and test. |
956e192 to
10ef612
Compare
10ef612 to
3790288
Compare
fixes #21137