Skip to content

Enable fmt-write-bloat for Windows #142841

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
bors merged 1 commit into from
Jun 22, 2025
Merged

Enable fmt-write-bloat for Windows #142841

bors merged 1 commit into from
Jun 22, 2025

Conversation

@dpaoliello
Copy link
Contributor

@dpaoliello dpaoliello commented Jun 21, 2025 •
edited
Loading

Seems to be working fine for MSVC once it has the correct binary name.

Addresses item in #128602

try-job: x86_64-mingw-*
try-job: x86_64-msvc-*
try-job: i686-msvc-*

@rustbot
Copy link
Collaborator

rustbot commented Jun 21, 2025

jieyouxu is not on the review rotation at the moment.
They may take a while to respond.

@rustbot
Copy link
Collaborator

rustbot commented Jun 21, 2025

r? @jieyouxu

rustbot has assigned @jieyouxu.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added A-run-make Area: port run-make Makefiles to rmake.rs S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Jun 21, 2025
@rustbot
Copy link
Collaborator

rustbot commented Jun 21, 2025

This PR modifies run-make tests.

cc @jieyouxu

@jieyouxu
Copy link
Member

jieyouxu commented Jun 22, 2025

@bors2 delegate=try
@bors2 try

@rust-bors
Copy link

rust-bors bot commented Jun 22, 2025

@dpaoliello can now perform try builds on this pull request

@rust-bors
Copy link

rust-bors bot commented Jun 22, 2025

⌛ Trying commit 33b3ea2 with merge f335da1…

To cancel the try build, run the command @bors2 try cancel.

@rust-bors
Copy link

rust-bors bot commented Jun 22, 2025

☀️ Try build successful (CI)
Build commit: f335da1 (f335da1046ddc4c9f75ad83c72feb85b7c046efb, parent: d4e1159b8c97478778b09a4cc1c7adce5653b8bf)

jieyouxu
jieyouxu approved these changes Jun 22, 2025
View reviewed changes
Copy link
Member

@jieyouxu jieyouxu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Kewl

@jieyouxu
Copy link
Member

jieyouxu commented Jun 22, 2025

Thanks
@bors r+ rollup

@bors
Copy link
Collaborator

bors commented Jun 22, 2025

📌 Commit 33b3ea2 has been approved by jieyouxu

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 22, 2025
@jhpratt jhpratt mentioned this pull request Jun 22, 2025
Merged
@bors bors merged commit cbfb654 into rust-lang:master Jun 22, 2025
10 checks passed
@rustbot rustbot added this to the 1.89.0 milestone Jun 22, 2025
@dpaoliello dpaoliello deleted the fmt-write-bloat branch June 23, 2025 16:58
ChrisDenton
ChrisDenton reviewed Jul 8, 2025
View reviewed changes
tests/run-make/fmt-write-bloat/rmake.rs
panic_syms.extend_from_slice(&["panicking", "panic_fmt", "pad_integral", "Display"]);
}
assert!(!any_symbol_contains("main", &panic_syms));
assert!(!any_symbol_contains(bin_name("main"), &panic_syms));
Copy link
Member

@ChrisDenton ChrisDenton Jul 8, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Won't this assert trivially pass if there are no symbols at all?

Copy link
Member

@jieyouxu jieyouxu Jul 9, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point, this should be more like a codegen test hmm

Copy link
Member

@jieyouxu jieyouxu Jul 9, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#143669

@jieyouxu jieyouxu mentioned this pull request Jul 9, 2025
Closed
@jieyouxu jieyouxu mentioned this pull request Nov 2, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ChrisDenton ChrisDenton ChrisDenton left review comments

@jieyouxu jieyouxu jieyouxu approved these changes

Assignees

@jieyouxu jieyouxu

Labels

A-run-make Area: port run-make Makefiles to rmake.rs S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

1.89.0

Development

Successfully merging this pull request may close these issues.

5 participants

@dpaoliello @rustbot @jieyouxu @bors @ChrisDenton