Skip to content

Conversation

@tshepang
Copy link
Member

These are changes I expect would not break anything.

For context, main Rust repo has started moving to new terminology.

Copy link
Member

@ChrisDenton ChrisDenton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's good to use consistent terminology across the project so I personally think this is a good idea. But I'll wait to see if other team members are on board.

@djc
Copy link
Contributor

djc commented Dec 23, 2025

I'd like a little more "proof" than a single PR making targeted changes. Is there a Zulip thread with discussion or an issue somewhere?

Copy link
Contributor

@djc djc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay, I read the PR conversation -- seems fine.

Copy link
Member

@rami3l rami3l left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! However, I would like to know if this migration is complete. Have you found any type names in this repo to be migrated as well, for example?

@tshepang
Copy link
Member Author

tshepang commented Dec 23, 2025

there is a whole bunch of "triple" in the code, some public... are there api users outside of rustup of anything in rustup

@rami3l
Copy link
Member

rami3l commented Dec 23, 2025

there is a whole bunch of "triple" in the code, some public... are there api users outside of rustup of anything in rustup

@tshepang I think rustup's API doesn't have any stability guarantees so you are free to break them as long as they are coherent, right here or in a subsequent update, as you like it.

@tshepang
Copy link
Member Author

am happy to do it in a future pr

@ChrisDenton ChrisDenton added this pull request to the merge queue Dec 24, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Dec 24, 2025
@ChrisDenton
Copy link
Member

ChrisDenton commented Dec 24, 2025

Unable to run test command: Os { code: 26, kind: ExecutableFileBusy, message: "Text file busy" }

Looks spurious. Retrying...

@ChrisDenton ChrisDenton added this pull request to the merge queue Dec 24, 2025
Merged via the queue into rust-lang:main with commit dbf86b9 Dec 24, 2025
29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants