Skip to content

Conversation

@newkit
Copy link
Member

@newkit newkit commented Dec 24, 2025

This addresses the enhancement described here:

When creating a VM, currently the usage of hugepages is mandatory, see here.

Let's add a flag in to the VM definition to switch off the usage of hugepages:

sap_vm_provision_kubevirt_vm_host_specifications_dictionary:
  example_host_specification_plan:
    host1: # Hostname, must be 13 characters or less
      # SMT-2 (i.e. 2 CPU Threads per CPU Core) is default for Intel CPU Hyper-Threading, optionally can be altered to SMT-1
      kubevirt_vm_cpu_smt: 2
      kubevirt_vm_cpu_cores: 2
      kubevirt_vm_memory_gib: 24
      hugepages: false # false | 1Gi | <hugepage size> 

When omitted / by default hugepages should be on to be backwards compatible.

@newkit newkit requested a review from marcelmamula December 24, 2025 11:03
Copy link
Contributor

@marcelmamula marcelmamula left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review done with few changes to be made

@marcelmamula marcelmamula changed the title Make VM memory configurable to use hugepages or not sap_vm_provision/kubevirt_vm: Make usage of hugepages configurable Jan 5, 2026
Copy link
Contributor

@marcelmamula marcelmamula left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Last name change before LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants