Skip to content

Conversation

@newkit
Copy link
Member

@newkit newkit commented Dec 24, 2025

Changed order of CNV HyperConverged instance creation and changed webhook endpoint name waiting.

This fixes issue 146 by adding more conditionals that have to be true when waiting for webhook endpoint in order to continue.

@newkit newkit requested a review from marcelmamula December 24, 2025 11:27
@marcelmamula marcelmamula changed the title Fix installation of CNV operator sap_hypervisor_node_preconfigure/kubevirt_vm: Fix installation of CNV operator Jan 5, 2026
@marcelmamula
Copy link
Contributor

@newkit This PR does not fix #146

It just moves webhook wait into task file created in previous PR, it does not change any order.

@newkit
Copy link
Member Author

newkit commented Jan 5, 2026

@newkit This PR does not fix #146

It just moves webhook wait into task file created in previous PR, it does not change any order.

@marcelmamula
Well, it does fix #146 since it adds more conditionals waiting for the webhook endpoint to be ready:

until: - __sap_hypervisor_node_preconfigure_register_webhook_check is defined - __sap_hypervisor_node_preconfigure_register_webhook_check.resources | length > 0 - __sap_hypervisor_node_preconfigure_register_webhook_check.resources[0].subsets is defined - __sap_hypervisor_node_preconfigure_register_webhook_check.resources[0].subsets | length > 0 - __sap_hypervisor_node_preconfigure_register_webhook_check.resources[0].subsets[0].addresses is defined - __sap_hypervisor_node_preconfigure_register_webhook_check.resources[0].subsets[0].addresses | length > 0

vs. before

until: webhook_service.resources | default([]) | length > 0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants