Skip to content

Conversation

@angrezichatterbox
Copy link
Member

Contributor checklist


Description

The PR adds the conjugate application and the necessary things needed to run an additional target. I have currently copied the existing storyboard of the app to be displayed for the conjugate app.

Related issue

@github-actions
Copy link

Thank you for the pull request! 💙

The Scribe-iOS team will do our best to address your contribution as soon as we can. If you're not already a member of our public Matrix community, please consider joining! We'd suggest that you use the Element client as well as Element X for a mobile app, and definitely join the General and iOS rooms once you're in. Also consider attending our bi-weekly Saturday dev syncs. It'd be great to meet you 😊

Note

Scribe uses Conventional Comments in reviews to make sure that communication is as clear as possible.

@github-actions
Copy link

Maintainer Checklist

The following is a checklist for maintainers to make sure this process goes as well as possible. Feel free to address the points below yourself in further commits if you realize that actions are needed :)

  • Tests for changes have been written and the CI unit test, linting and formatting workflows within the PR checks do not indicate new errors in the files changed

  • The CHANGELOG has been updated with a description of the changes for the upcoming release and the corresponding issue (if necessary)

@andrewtavis
Copy link
Member

@angrezichatterbox, do you have an idea of what the issue with the CI tests is?

@andrewtavis
Copy link
Member

Thanks for opening the PR, btw! Amazing that we have progress on both projects now 😊

@angrezichatterbox
Copy link
Member Author

@angrezichatterbox, do you have an idea of what the issue with the CI tests is?

I will look into it and fix it later today.

@angrezichatterbox
Copy link
Member Author


  Error: fatal: remote error: upload-pack: not our ref 7b944ab4384e7d4268e5afe29bd77b30b014428f
  Error: fatal: Fetched in submodule path 'Scribe/i18n', but it did not contain 7b944ab4384e7d4268e5afe29bd77b30b014428f. Direct fetching of that commit failed.
  Error: The process '/opt/homebrew/bin/git' failed with exit code 128

Does this mean that the current iOS repository uses Scribe-i18n commit which no longer exists in Scribe-i18n.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants