Skip to content

feat: conbineAsync #31

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
seangwright merged 17 commits into from
Apr 8, 2025
Merged

feat: conbineAsync #31

seangwright merged 17 commits into from
Apr 8, 2025

Conversation

@GregOnNet
Copy link
Contributor

@GregOnNet GregOnNet commented Mar 17, 2025 •
edited
Loading

To-do

  • Handle one successful ResultAsync
  • Handle failed ResultAsync
  • Handle collection of ResultAsync
  • Handle one resolved Promise
  • Handle rejected Promise
  • Handle collection of ResultAsync | Promise
  • Handle successful Result
  • Handle failed Result
  • Handle collection of ResultAsync | Result
  • Add combineAsync to Result<T>
  • Clean up code

Closes #27

@GregOnNet GregOnNet force-pushed the feature/combine-async branch from c65812f to a0fd2c1 Compare March 17, 2025 12:55
@GregOnNet GregOnNet changed the title chore(vscode): accept automatic change made by vsCode feat: conbineAsync Mar 17, 2025
@GregOnNet GregOnNet force-pushed the feature/combine-async branch from 36eb330 to 54b4e7b Compare March 18, 2025 09:12
GregOnNet
GregOnNet commented Mar 18, 2025
View reviewed changes
@GregOnNet
test(combine): simplify all test cases
e88b136
@GregOnNet
ref(combine): simplify iteration over record
4972d4e
@GregOnNet
feat(combine): remove support for Promises
76a24e8 
- it technically works fine
- but Promise Error is not the same as a Failure
- so we need to guess the error message and we do not know the type of the error of the promise
- it is better to wrap the Promise in a ResultAsync first specifying a human readable failure
@GregOnNet
ref(combine): clean up type names
5ec993f
@GregOnNet
fix(combine): correct wrong import
c38640f
@GregOnNet GregOnNet marked this pull request as ready for review March 18, 2025 12:58
@GregOnNet GregOnNet requested a review from seangwright March 24, 2025 05:45
@GregOnNet
Copy link
Contributor Author

GregOnNet commented Mar 29, 2025

@seangwright thid PR is ready to Review.

@seangwright seangwright merged commit 62ccfb0 into seangwright:main Apr 8, 2025
2 checks passed
@seangwright seangwright mentioned this pull request Apr 26, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@seangwright seangwright Awaiting requested review from seangwright

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Feature: combineAsync

2 participants

@GregOnNet @seangwright