-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
chore: replace deprecated serde_yaml v0.9.28 with serde_yaml_ng v0.10.0 #3480
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
chore: replace deprecated serde_yaml v0.9.28 with serde_yaml_ng v0.10.0 #3480
Conversation
Enselic
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If we switch crate it must be after there is broad consensus on what to use instead. This crate is nowhere near that level of adoption.
|
Hi @Enselic, thanks for the review! I completely understand the hesitation currently. We can always migrate when the consensus is reached. In the meantime, I would leave a few links here:
|
|
Isn't saphyr the best one here? |
|
I could change it to use |
|
Regardless, its the only safest (no unsafe) pure rust yaml implementation, thats still maintained well. See readme of https://github.com/bourumir-wyngs/serde-yaml-bw To know the weird status of yaml in rust. |
|
Yep, I did go through it as I was looking at the alternatives, if consensus is reached, I could go ahead with the change. @Enselic, would it be okay if we switch to the |
|
Also serde docs.rs page recommends serde_yaml, which is weird. Because of this, adoption is a bit slow. (One needs to go through the rabbithole). |
Hi folks,
Just a small PR. Updated the
serde_yamlcrate to a maintained forkserde_yaml_ngsee fixes #3164