fix: reorder builtin decoration transformers #1174
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix:
metaHighlightWordfails withtwoslashDescription
Fixes an issue where
metaHighlightWord(and other decorations) would throw "Invalid decoration offset" errors when used in conjunction withtwoslash.Changes
packages/corebuiltInTransformers(which includes transformerDecorations) to run before other transformers in getTransformers.transformerTwoslashmodifies the HAST structure (e.g., adding error lines, popups). If transformerDecorations runs aftertransformerTwoslash, it attempts to apply decorations based on the original code offsets to a modified HAST, causing mismatches. Running decorations first ensures they are applied to the correct structure.packages/twoslashdecorationsin the recursive codeToHast call within rendererRich.decorationsfrom the parent context. Since the popup content is different from the main code, applying these decorations caused invalid offset errors.Reproduction
Checklist
closes: #990