fix(transformers): preserve empty lines with annotations #1218
+14
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for shiki-next ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for shiki-matsu ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1218 +/- ##
=======================================
Coverage 95.20% 95.20%
=======================================
Files 92 92
Lines 7922 7925 +3
Branches 1689 1690 +1
=======================================
+ Hits 7542 7545 +3
Misses 374 374
Partials 6 6 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #589
Description
Previously, the notation transformer would unconditionally remove lines that became empty after comment removal, even if those lines were targeted by annotations (e.g.,
// [code app/Models/InstanceSettings.php highlight]).This PR modifies the removal logic to check if the line has any CSS classes other than the default
line. If it does (meaning it was highlighted, focused, etc.), the line is preserved.Changes
packages/transformers/src/shared/notation-transformer.tsto check for additional classes before removing empty lines.packages/transformers/test/fixtures/highlight/preserve-empty.js.