refactor: replace NgClass by modern class syntax for various components part 2

[spliffone]

Describe in detail what your merge request does and why. Add relevant
screenshots and reference related issues via Closes #XY or Related to #XY.

---

• I confirm that this MR follows the contribution guidelines.

[gemini-code-assist]

Summary of Changes

Hello @spliffone, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request refactors the menu components by transitioning from the NgClass directive to a more modern and concise [class] binding approach for dynamic CSS class assignments. This change streamlines the template code, improves readability, and removes an unnecessary dependency, aligning the components with current Angular best practices for styling.

Highlights

• Template Syntax Update: Replaced the use of [ngClass] with direct [class] binding for dynamically setting badge background colors in the si-menu-item-checkbox, si-menu-item-radio, and si-menu-item templates. This leverages modern Angular template literal syntax for class assignment.
• Dependency Removal: Removed NgClass from the imports array in the component definitions for SiMenuItemCheckboxComponent, SiMenuItemRadioComponent, and SiMenuItemComponent, as it is no longer required after the template syntax refactoring.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request refactors menu components to replace the NgClass directive with modern [class] binding syntax. The changes are correct and effectively remove the dependency on NgClass, which is a good modernization step. I've added one comment regarding code duplication that this refactoring introduces across multiple templates. While the current change is an improvement, centralizing the new logic in the base class would be a good follow-up to improve long-term maintainability.

[github-actions]

Documentation.
Examples.
Playwright report.

Coverage Reports:

• element-ng
• element-translate-ng

[github-actions]