Skip to content

Conversation

@pmachapman
Copy link
Collaborator

@pmachapman pmachapman commented Jan 27, 2026

This PR allows selection of a verse in the Community Checking Questions and Answers area, and have the selected verse become the verse reference for that question when you click "Add Question".

As a part of this, clicking on a verse if you have the permission to create questions will highlight that verse in the text in Community Checking.


This change is Reviewable

@pmachapman pmachapman added the will require testing PR should not be merged until testers confirm testing is complete label Jan 27, 2026
@codecov
Copy link

codecov bot commented Jan 27, 2026

Codecov Report

❌ Patch coverage is 87.50000% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 81.96%. Comparing base (bd581f7) to head (8dc83dd).
✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
...pp/src/app/checking/checking/checking.component.ts 80.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master    #3652   +/-   ##
=======================================
  Coverage   81.95%   81.96%           
=======================================
  Files         618      618           
  Lines       38494    38501    +7     
  Branches     6300     6301    +1     
=======================================
+ Hits        31549    31556    +7     
  Misses       5984     5984           
  Partials      961      961           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@RaymondLuong3 RaymondLuong3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a nice improvement!

@RaymondLuong3 reviewed 4 files and all commit messages, and made 1 comment.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @pmachapman).

@RaymondLuong3 RaymondLuong3 added ready to test and removed will require testing PR should not be merged until testers confirm testing is complete labels Jan 30, 2026
@RaymondLuong3 RaymondLuong3 self-assigned this Jan 30, 2026
@RaymondLuong3
Copy link
Collaborator

Please also update the commit message to be more meaningful and descriptive of the user facing change.

@pmachapman pmachapman changed the title SF-3677 User selection is disregarded by the New Question dialog SF-3677 Use the verse the user has selected in the New Question dialog Feb 1, 2026
Copy link
Collaborator Author

@pmachapman pmachapman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please also update the commit message to be more meaningful and descriptive of the user facing change.

Is this clearer?

@pmachapman made 1 comment.
Reviewable status: all files reviewed (commit messages unreviewed), all discussions resolved (waiting on @pmachapman).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants