-
Notifications
You must be signed in to change notification settings - Fork 2
refactor the towersit system #50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
we need to fix CI at some point |
|
LabAPI pr is merged so everything should hopefully work when sl updates |
|
Why is this draft? |
|
Because until labapi updates it's broken |
|
i decided to use a harmony patch so the file can just be deleted when LabAPI works |
|
also its still gonna be broken with players with goggles and it doesn't account for any effects a player might have |
|
I'm not entirely sure how to make the goggles drop instantly |
|
What about getting players location prior to teleport and placing a googles there, then deleting the old goggles and undoing the effect from player |
|
Not sure why you’d drop them if they’re in a sit tho doesn’t seem very beneficial |
|
So if you don't drop the items the garbage collector just entirely deletes the players shit if their inventory is cleared and there's no way to get it back without substantial work Which is why we drop all the players items and then teleport them above the tutorial tower and freeze the physics But |
|
@blankochan Server.Host.AddItems() ? Just give the items to the server and save the references. |
|
Did not think about the fact that the server is technically a player, I'll play with that for a bit, but that might break really quickly if there is ever 2 players in a sit and there's more than 8 items across the two players |
|
Item limit is checked before picking up the item, never after, so inventory won't be checked. |
|
not ready yet but i wanted to get it out before my tournament match |
something quick to note
this is gonna is currently broken on LabAPI and will be until this gets merged
goggles is also broken, if someone has goggles its gonna force them to take them off which causes all sorts of jank