feat: add a happy path open source test for 'snyk test' with --risk-score-threshold #6302
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bsalomon-snyk
force-pushed
the
feat/osflows-riskscore-tests
branch
from
46a4e97 to
4845cbc
Compare
emily-lynn-minor
force-pushed
the
feat/osflows-riskscore-tests
branch
4 times, most recently
from
5a89e6e to
3ceabcd
Compare
- Adds happy path tests with --risk-score-threshold=400, ensuring
all risk scores returned are >= 400. There is one test each for human-readable-
and JSON- outputs.
- Tests --risk-score-threshold with .snyk local policy, with and without --ignore-policy.
These check for counts on the separate "Ignored: " lines for vulnerabilities and licenses.
emily-lynn-minor
force-pushed
the
feat/osflows-riskscore-tests
branch
from
3ceabcd to
776a1cd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Submission Checklist
are release-note ready, emphasizing
what was changed, not how.
What does this PR do?
Adds a happy path open source test for 'snyk test' with --risk-score-threshold. This feature currently runs only with feature flags set.
Low risk -- affects test only.
Where should the reviewer start?
Note that the two Risk Score feature flags default false for the overall test suite. This test file sets them true in order to trigger the Unified Test API code path, which includes risk score enrichment.
How should this be manually tested?
It can be run from the CLI root with
npx jest --runInBand test/jest/acceptance/snyk-test/risk-score-threshold.spec.tsWhat's the product update that needs to be communicated to CLI users?
No impact on application; test only.
Risk assessment (Low | Medium | High)? Low
What are the relevant tickets?
https://snyksec.atlassian.net/browse/DGP-802
https://snyksec.atlassian.net/browse/DGP-1084