refactor middleware

[huseeiin]

i deleted some stuff like deprecation warnings please tell me if they should stay
currently in v2 when you do:

import { createMiddleware } from "@solidjs/start/middleware";

export default createMiddleware({
    onBeforeResponse: (e, response) => {
        console.log(response);
    },
});

response.body is undefined
that is fixed
also, there's a new breaking change (relative to start v1): response is now Response instead of { body: ReadableStream | string } (ReadableStream if mode is "stream", string otherwise)

[changeset-bot]

🦋 Changeset detected

Latest commit: d815753

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

[netlify]

✅ Deploy Preview for solid-start-landing-page ready!

Name	Link
🔨 Latest commit	d815753
🔍 Latest deploy log	https://app.netlify.com/projects/solid-start-landing-page/deploys/69651ddf2bad1b00089eb5de
😎 Deploy Preview	https://deploy-preview-2047--solid-start-landing-page.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

---

To edit notification comments on pull requests, go to your Netlify project configuration.

[pkg-pr-new]

Open in StackBlitz

npm i https://pkg.pr.new/solidjs/solid-start/@solidjs/start@2047

npm i https://pkg.pr.new/solidjs/solid-start/@solidjs/vite-plugin-nitro-2@2047

commit: d815753

[katywings]

Imho the deprecation warnings should stay 🤔. Afaik the end goal is that users ideally will just use h3 middleware and we only keep createMiddleware for backwards compatibility.

[katywings]

Whats the advantage of the response clone? Couldn't the enduser do it themselves? 🤔

[huseeiin]

Whats the advantage of the response clone? Couldn't the enduser do it themselves? 🤔

they can do it themselves, but first they have to know why they should: they use response.text() then get shocked that it fails because the response body is already used by the framework

[lxsmnsyc]

cloning is fine, I also did it a lot of times in the seroval branch. It's a workaround for expected issues like what he mentioned

[huseeiin]

Imho the deprecation warnings should stay 🤔. Afaik the end goal is that users ideally will just use h3 middleware and we only keep createMiddleware for backwards compatibility.

but how do they use h3 middleware?

[huseeiin]

tip for users, when you do this:

export default createMiddleware({
    onBeforeResponse: async (e, r) => {
        console.log(await r.text());
    },
});

and you're streaming, your stream will be deferred.
to avoid that, you can use h3's waitUntil but by then you've left the request and can't respond with your modified response.

export default createMiddleware({
    onBeforeResponse: (e, r) => {
        e.nativeEvent.waitUntil((async () => {
            console.log(await r.text());
        })());
    },
});

[huseeiin]

it seems this crashes with ERROR Worker error: Invalid state: ReadableStream is locked when i refresh many times. converting to draft