Skip to content

Conversation

@CarolineDenis
Copy link
Contributor

@CarolineDenis CarolineDenis commented Aug 14, 2025

Fixes #6213

Screenshot 2026-01-07 at 11 56 32

Checklist

  • Self-review the PR after opening it to make sure the changes look good and
    self-explanatory (or properly documented)
  • Add relevant issue to release milestone
  • Add pr to documentation list
  • Add automated tests
  • Add a reverse migration if a migration is present in the PR

Testing instructions

Notes: Taxon will be created for a discipline in the tree viewer not in the config tool / tree config will be added and evaluated once this pr and the tree default creation are merged in the setup pr

General

  • Open the System Config Tool (available from the User Tools menu).

Hierarchy Display

  • Verify that existing Institutions → Divisions → Disciplines → Collections are displayed in the left hierarchy tree.
  • Verify that each section in the left hierarchy tree can be expanded and collapsed.
  • Verify that existing Institutions → Divisions → Disciplines → Collections are displayed in the right tree visualization.
  • Verify that the orientation of the right tree visualization can be switched between horizontal and vertical.
  • Verify that clicking Edit next to any resource in the left hierarchy tree opens a dialog with the resource details.
  • Verify that clicking any resource in the right tree visualization opens a dialog with the resource details.

New Resource Creation


Edit Function

  • Verify that newly created resources appear in both hierarchy trees.
  • Verify that you can edit an existing resource and successfully save the changes.

Delete Function

  • Verify that a resource cannot be deleted if it is in use
    (e.g., a Discipline containing a Collection with data).

  • Verify that a resource can be deleted if it is not in use
    (e.g., a Discipline with only empty Collections).

    • Deleting a Discipline should also delete its empty Collections.

@CarolineDenis CarolineDenis added this to the 7.12.0 milestone Aug 14, 2025
@github-project-automation github-project-automation bot moved this to 📋Back Log in General Tester Board Aug 14, 2025
@CarolineDenis CarolineDenis changed the title Issue 6213 1 Create a configuration tool Aug 14, 2025
@CarolineDenis CarolineDenis changed the base branch from main to issue-2931-1 August 14, 2025 19:12
@CarolineDenis
Copy link
Contributor Author

CarolineDenis commented Aug 19, 2025

  • Add a migration to create a pick list for discipline type field.

Discipline section:
For geography rank configuration, taxon rank configuration, and tree creation:
After adding a new discipline, the page will reload and the discipline will appear in the hierarchy display. Next to the new discipline, two icons will be shown: a globe and a tree. A red warning message will also appear, prompting the user to configure both the taxon tree and the geography tree. The globe icon is conditional—if the geography tree is set to global, it will not be displayed.
When the user clicks on either the tree or globe icon, a dialog will open containing the corresponding rank configuration form. Once both configurations are saved, a “+” icon will appear next to the discipline, allowing the user to add a new collection.

@CarolineDenis CarolineDenis mentioned this pull request Aug 19, 2025
51 tasks
Copy link
Contributor

@alesan99 alesan99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Verify that existing Institutions → Divisions → Disciplines → Collections are displayed in the left hierarchy tree.
  • Verify that each section in the left hierarchy tree can be expanded and collapsed.
  • Verify that existing Institutions → Divisions → Disciplines → Collections are displayed in the right tree visualization.
  • Verify that the orientation of the right tree visualization can be switched between horizontal and vertical.
  • Verify that clicking Edit next to any resource in the left hierarchy tree opens a dialog with the resource details.
  • Verify that clicking any resource in the right tree visualization opens a dialog with the resource details.
  • Verify that the right tree visualization supports scrolling vertically and horizontally.
  • Verify that newly created resources appear in both hierarchy trees.
  • Verify that you can edit an existing resource and successfully save the changes.
  • Verify that a resource cannot be deleted if it is in use
  • Verify that a resource can be deleted if it is not in use

Everything works 👍

The resources are also being updated without having to clear the cache as well.,

Tree creation for new disciplines doesn't entirely work correctly in this PR, but that's only because the Setup PR #6671 still needs improvements with tree creation.

Copy link
Member

@grantfitzsimmons grantfitzsimmons left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

General

  • Open the System Config Tool (available from the User Tools menu).

Hierarchy Display

  • Verify that existing Institutions → Divisions → Disciplines → Collections are displayed in the left hierarchy tree.
  • Verify that each section in the left hierarchy tree can be expanded and collapsed.
  • Verify that existing Institutions → Divisions → Disciplines → Collections are displayed in the right tree visualization.
  • Verify that the orientation of the right tree visualization can be switched between horizontal and vertical.
  • Verify that clicking Edit next to any resource in the left hierarchy tree opens a dialog with the resource details.
  • Verify that clicking any resource in the right tree visualization opens a dialog with the resource details.

New Resource Creation

  • Click Add {resource name} (Division, Discipline, or Collection).

  • Fill in the form.

  • Click Save.

I had some trouble here. I created a new Discipline and Collection under an existing Division:

Image Image

The new collection is "Example Insect Collection". I can switch to it, log in, but the schema doesn't exist.

  • Navigating to the Schema Config and selecting a table (e.g. Preparation), I get the following error: Error: Unable to find SpLocaleContainer for Preparation

Some resources seem to have been created correctly based on my discipline– for example, preptype records:

Image

Strangely, when I go to the 'Taxon' tree, I see an 'Animalia' node. Not relevant to insects and I would expect "Life" to be the only node:

Image

It is correctly fetching the default forms for the insect discipline.


Edit Function

  • Verify that newly created resources appear in both hierarchy trees.
  • Verify that you can edit an existing resource and successfully save the changes.

Even in cases where the changes are made to the forms of the resources, it does fetch the changes immediately. Looks good!


Delete Function

  • Verify that a resource cannot be deleted if it is in use
    (e.g., a Discipline containing a Collection with data).
  • Verify that a resource can be deleted if it is not in use
  • Deleting a Discipline should also delete its empty Collections.

@github-project-automation github-project-automation bot moved this from 📋Back Log to Dev Attention Needed in General Tester Board Jan 7, 2026
@alesan99
Copy link
Contributor

alesan99 commented Jan 7, 2026

The new collection is "Example Insect Collection". I can switch to it, log in, but the schema doesn't exist.

This should be fixed now 👍
Since schema config creation takes a while you may now get a timeout error though, but that would be solved by schema config speedups described in this issue: #7615

Strangely, when I go to the 'Taxon' tree, I see an 'Animalia' node. Not relevant to insects and I would expect "Life" to be the only node:

Any tree issues will be sorted once #7593 combines the functionality of the default tree creation PR and the setup PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Dev Attention Needed

Development

Successfully merging this pull request may close these issues.

[System Config Tool]: Add a new configuration page to create new Discipline, Division, Collection

5 participants