-
Notifications
You must be signed in to change notification settings - Fork 41
Create a configuration tool #7312
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: issue-2931-1
Are you sure you want to change the base?
Conversation
e86d628 to
22ca396
Compare
11b3023 to
4a6da84
Compare
015e7e5 to
4396b60
Compare
dfd7ce5 to
4bace18
Compare
Triggered by 6f46015 on branch refs/heads/issue-6213-1
Discipline section: |
alesan99
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Verify that existing Institutions → Divisions → Disciplines → Collections are displayed in the left hierarchy tree.
- Verify that each section in the left hierarchy tree can be expanded and collapsed.
- Verify that existing Institutions → Divisions → Disciplines → Collections are displayed in the right tree visualization.
- Verify that the orientation of the right tree visualization can be switched between horizontal and vertical.
- Verify that clicking Edit next to any resource in the left hierarchy tree opens a dialog with the resource details.
- Verify that clicking any resource in the right tree visualization opens a dialog with the resource details.
- Verify that the right tree visualization supports scrolling vertically and horizontally.
- Verify that newly created resources appear in both hierarchy trees.
- Verify that you can edit an existing resource and successfully save the changes.
- Verify that a resource cannot be deleted if it is in use
- Verify that a resource can be deleted if it is not in use
Everything works 👍
The resources are also being updated without having to clear the cache as well.,
Tree creation for new disciplines doesn't entirely work correctly in this PR, but that's only because the Setup PR #6671 still needs improvements with tree creation.
grantfitzsimmons
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
General
- Open the System Config Tool (available from the User Tools menu).
Hierarchy Display
- Verify that existing Institutions → Divisions → Disciplines → Collections are displayed in the left hierarchy tree.
- Verify that each section in the left hierarchy tree can be expanded and collapsed.
- Verify that existing Institutions → Divisions → Disciplines → Collections are displayed in the right tree visualization.
- Verify that the orientation of the right tree visualization can be switched between horizontal and vertical.
- Verify that clicking Edit next to any resource in the left hierarchy tree opens a dialog with the resource details.
- Verify that clicking any resource in the right tree visualization opens a dialog with the resource details.
New Resource Creation
Click Add {resource name} (Division, Discipline, or Collection).
Fill in the form.
- Note: For Disciplines, the Type field must currently be entered manually in this PR.
The pick list is implemented in a separate PR:
https://github.com/specify/specify7/pull/7584/filesClick Save.
I had some trouble here. I created a new Discipline and Collection under an existing Division:
The new collection is "Example Insect Collection". I can switch to it, log in, but the schema doesn't exist.
- Navigating to the Schema Config and selecting a table (e.g.
Preparation), I get the following error:Error: Unable to find SpLocaleContainer for Preparation
Some resources seem to have been created correctly based on my discipline– for example, preptype records:
Strangely, when I go to the 'Taxon' tree, I see an 'Animalia' node. Not relevant to insects and I would expect "Life" to be the only node:
It is correctly fetching the default forms for the insect discipline.
Edit Function
- Verify that newly created resources appear in both hierarchy trees.
- Verify that you can edit an existing resource and successfully save the changes.
Even in cases where the changes are made to the forms of the resources, it does fetch the changes immediately. Looks good!
Delete Function
- Verify that a resource cannot be deleted if it is in use
(e.g., a Discipline containing a Collection with data).- Verify that a resource can be deleted if it is not in use
- Deleting a Discipline should also delete its empty Collections.
Triggered by a1e073b on branch refs/heads/issue-6213-1
This should be fixed now 👍
Any tree issues will be sorted once #7593 combines the functionality of the default tree creation PR and the setup PR. |
Fixes #6213
Checklist
self-explanatory (or properly documented)
Testing instructions
Notes: Taxon will be created for a discipline in the tree viewer not in the config tool / tree config will be added and evaluated once this pr and the tree default creation are merged in the setup pr
General
Hierarchy Display
New Resource Creation
Click Add {resource name} (Division, Discipline, or Collection).
Fill in the form.
The pick list is implemented in a separate PR:
https://github.com/specify/specify7/pull/7584/files
Click Save.
Edit Function
Delete Function
Verify that a resource cannot be deleted if it is in use
(e.g., a Discipline containing a Collection with data).
Verify that a resource can be deleted if it is not in use
(e.g., a Discipline with only empty Collections).