-
-
Notifications
You must be signed in to change notification settings - Fork 4
Use text as media file title on upload #43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
spencerc99
wants to merge
12
commits into
main
Choose a base branch
from
claude/text-as-media-title-019cdWELFWaoZ65yvkvaTTrW
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Use text as media file title on upload #43
spencerc99
wants to merge
12
commits into
main
from
claude/text-as-media-title-019cdWELFWaoZ65yvkvaTTrW
+365
−144
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When uploading exactly one media file with text in the texting view, the text is now used as the title for the media file instead of creating a separate text block. This provides a more intuitive captioning experience.
Remove the donation/contribution prompt from Android onboarding flow. Users can now experience the app first before being prompted to contribute, matching the iOS behavior. Contributions are still accessible via the support page and milestone-based prompts.
…tion UI - Add @ trigger in texting view for collection autocomplete - Selected collections appear as removable chips above input - Blocks are now connected to all selected collections when saved - Move "New Collection" button inline with search bar in collection select - Update CHANGELOG with new features
- Move collection selector from header to near the input area - Add "In: [collection name]" indicator with folder-open icon - Visually distinguish context (where you're viewing) from @ mentions (destinations) - Add triggerIcon and triggerPrefix props to CollectionSelect for customization - Remove header title in ChatDetailView since selection is now near input
57539a3 to
e00c12e
Compare
Deploying gather with
|
| Latest commit: |
963fd9e
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://e17470f1.gather-6dw.pages.dev |
| Branch Preview URL: | https://claude-text-as-media-title-0.gather-6dw.pages.dev |
- Use TouchableOpacity instead of Pressable for better tap handling in FlatList - Reorder layout: collection context row first, then media assets, then autocomplete - This ensures media previews appear below the collection info as requested
- Reduce CollectionSelect trigger size with maxWidth and smaller padding
- Hide chevron and use shorter placeholder to match chip style
- Use same border-radius and padding as @ mention chips
- Add text truncation with numberOfLines={1} and flexShrink
- Remove divider for cleaner row of chips
- Add maxWidth to @ mention chips for consistency
- Use unstyled Select.Trigger to remove default Tamagui styling - Use pixel values for consistent sizing across chips - Reduce padding (8px horizontal, 4px vertical) and border-radius (12px) - Use lighter orange ($orange4) for less visual weight - Smaller icons (12px) and gaps (4px) - Remove elevation for flatter, minimal appearance
- Remove @ chip when switching "In:" collection to one already mentioned - Filter current "In:" collection from @ autocomplete suggestions - Fix CollectionSelect width to not stretch unnecessarily (use flexGrow: 0, flexShrink: 0)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.