Skip to content

Add ty type checker and fix errors #114

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
elbersb wants to merge 18 commits into
base: master
Choose a base branch
from
Open

Add ty type checker and fix errors #114

elbersb wants to merge 18 commits into from

Conversation

@elbersb
Copy link
Collaborator

@elbersb elbersb commented Jan 13, 2026 •
edited
Loading

  • Adds ty as the default type checker
  • Fixes ~300 errors that ty identifies
  • Removes unused functions (dead code)
    • bayesian_base.py: _all_groups - unused method
    • bayesian_base.py: as_cumulative - unused (and broken) classmethod
    • confidence_utils.py: applyParallel - an unused parallel apply function for DataFrames
    • sample_size_computer.py: compute_summary - unused (and broken) method for computing summary statistics
    • constants.py: Z_CRIT, CORRECTION_METHODS_THAT_DONT_REQUIRE_METRIC_INFO

elbersb added 18 commits January 13, 2026 15:54
@elbersb
Add ty
2596ac2
@elbersb
Two lines added: @AbstractMethod decorators for methods that already …
38c2b4f 
…had empty bodies
@elbersb
Add Optional for types that can be None
feea925
@elbersb
Continued fixing invalid-parameter-default errors by adding Optional[…
4d71acb 
…Type] annotations
@elbersb
Remove dead code: unused functions, constants, and commented stubs
597f784
@elbersb
Fix more return types
7694213
@elbersb
Fix unresolved-attribute, not-subcriptable, invalid-type-form, possib…
d80b12d 
…ly-missing-attribute
@elbersb
Fix no-matching-overload, invalid-assignment, invalid-return-type
287bd0b
@elbersb
Fix invalid argument types
ce3ce3f
@elbersb
Fix: invalid-return-type
8be7cfb
@elbersb
Fix unsupported-operator errors
9c7d194
@elbersb
Start tackling invalid-argument-type
9753da4
@elbersb
Added more optional types
3f11dda
@elbersb
Fix remaining invalid-argument-type
c1935ee
@elbersb
First round of fixing tests
30e0aef
@elbersb
Fix more test errors
c35b393
@elbersb
Fix remaining checks
51523ad
@elbersb
Fixes required for py 3.9 specifically (old pandas type stubs)
d9fb120
@elbersb elbersb marked this pull request as ready for review January 14, 2026 10:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@elbersb