Add FileSystem.lock (#1869) #1677
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit introduces file locking capabilities to the Okio FileSystem. Key changes: - Added `FileSystem.lock()` method to acquire exclusive or shared locks on files. - Implemented `FileLock` interface for managing lock state and lifecycle. - Provided JVM-specific implementation using `java.nio.channels.FileChannel.lock()`. - Added `FakeFileSystemLock` for testing purposes. - Included base and platform-specific tests for file locking functionality. - Default implementations in common, JS, Native, and Wasm `FileSystem` throw `IOException` as locking is not supported on these platforms by default. - Updated `NioFileSystemWrappingFileSystem` and `JvmSystemFileSystem` to delegate to the new locking mechanism.
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit introduces file locking capabilities to the Okio FileSystem.
For discussion of #1464
TODO
proper-lockfile?Key changes:
FileSystem.lock()method to acquire exclusive or shared locks on files.FileLockinterface for managing lock state and lifecycle.java.nio.channels.FileChannel.lock().FakeFileSystemLockfor testing purposes.FileSystemthrowIOExceptionas locking is not supported on these platforms by default.NioFileSystemWrappingFileSystemandJvmSystemFileSystemto delegate to the new locking mechanism.