feat: add per-project MCP config overrides #5406
Open
+319
−20
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
/review |
Contributor
|
lgtm |
Allow project configs to override the 'enabled' field of MCP servers defined in global config without redefining the full configuration. This enables two patterns: - Define MCPs globally, disable per-project - Define MCPs globally disabled, enable per-project Added 'Missing configuration' error when an override references an MCP that has no base config defined. UI: Right-align MCP status labels in sidebar to match Modified Files.
Update plugin package and plugin loader to import from @opencode-ai/sdk/v2 instead of the legacy v1 SDK. Required for compatibility with McpOverrideConfig type added in the MCP config overrides feature.
Add type guard functions to safely distinguish between full MCP configs (local/remote) and override-only configs which only have the 'enabled' field. - Add isFullMcpConfig, isLocalMcpConfig, isRemoteMcpConfig helpers - Update MCP CLI commands to use type guards - Update OAuth flow to use type guards - Filter override configs when adding MCP servers via ACP Fixes type errors introduced by McpOverrideConfig in the per-project MCP config overrides feature.
This reverts commit 4e42c69.
Collaborator
|
/review |
Contributor
|
lgtm |
# Conflicts: # packages/opencode/src/cli/cmd/mcp.ts
# Conflicts: # packages/opencode/test/config/config.test.ts # packages/web/src/content/docs/mcp-servers.mdx
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow project configs to override the 'enabled' field of MCP servers defined in global config without redefining the full configuration. This enables two patterns:
Added 'Missing configuration' error when an override references an MCP that has no base config defined.
UI: Right-align MCP status labels in sidebar to match Modified Files.
As discussed in #4525.