fix: variants for custom models #6471
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rekram1-node
changed the title
| release_date: model.release_date ?? existingModel?.release_date ?? "", | ||
| variants: {}, | ||
| } | ||
| parsedModel.variants = mapValues(ProviderTransform.variants(parsedModel), (v) => ({ disabled: false, ...v })) |
Collaborator
There was a problem hiding this comment.
this has a bug actually...
Collaborator
There was a problem hiding this comment.
doesnt allow user to disable variants
There was a problem hiding this comment.
doesnt allow user to disable variants
#6477 tested this one. Seems to be working on codex-oauth - cycles through entries and changes reasoning effort.
Contributor
Author
|
I figured letting the variant function do the work deciding which variants are available would be fine? Users still can cycle to no variant option if they want, and by default a variant is not picked for them. If you want to go a different route let me know, i'll close this one |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Models defined in user config (opencode.jsonc) with custom providers now get auto-generated variants via
ProviderTransform.variants().