Skip to content

Python 3.10 support #60

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
ivhacks wants to merge 2 commits into from
Closed

Python 3.10 support #60

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
694bac5
Fix typo
ivhacks May 23, 2022
47b4ccf
fix: update for py3.10 collections breaking change
Dec 2, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions stagger/frames.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -114,7 +114,7 @@ def _in_version(self, *versions):
"Returns true if this frame is in any of the specified versions of ID3."
for version in versions:
if (self._version == version
or (isinstance(self._version, collections.Container)
or (isinstance(self._version, collections.abc.Container)
and version in self._version)):
return True
return False
Expand Down Expand Up @@ -244,7 +244,7 @@ def extract_strs(values):
return
if isinstance(values, str):
yield values
elif isinstance(values, collections.Iterable):
elif isinstance(values, collections.abc.Iterable):
for val in values:
for v in extract_strs(val):
yield v
Expand Down
6 changes: 3 additions & 3 deletions stagger/tags.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -219,7 +219,7 @@ def __repr__(self):
return "<FrameOrder: {0}>".format(", ".join(pair[0] for pair in order))


class Tag(collections.MutableMapping, metaclass=abc.ABCMeta):
class Tag(collections.abc.MutableMapping, metaclass=abc.ABCMeta):
known_frames = { } # Maps known frameids to Frame class objects

frame_order = None # Initialized by stagger.id3
Expand Down Expand Up @@ -316,7 +316,7 @@ def __setitem__(self, key, value):
self._frames[key] = [value]
return
if self.known_frames[key]._allow_duplicates:
if not isinstance(value, collections.Iterable) or isinstance(value, str):
if not isinstance(value, collections.abc.Iterable) or isinstance(value, str):
raise ValueError("{0} requires a list of frame values".format(key))
self._frames[key] = [val if isinstance(val, self.known_frames[key])
else self.known_frames[key](val)
Expand Down Expand Up @@ -359,7 +359,7 @@ def values(self):
disc_total = abstractproperty(fget=lambda self: None, fset=lambda self, value: None)
composer = abstractproperty(fget=lambda self: None, fset=lambda self, value: None)
genre = abstractproperty(fget=lambda self: None, fset=lambda self, value: None)
comment = abstractproperty(fget=lambda self: Non, fset=lambda self, value: None)
comment = abstractproperty(fget=lambda self: None, fset=lambda self, value: None)
grouping = abstractproperty(fget=lambda self: None, fset=lambda self, value: None)
picture = abstractproperty(fget=lambda self: None, fset=lambda self, value: None)
sort_title = abstractproperty(fget=lambda self: None, fset=lambda self, value: None)
Expand Down