Update express to 4.21 #1
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
|
Hey Michael, unfortunately, I don't have the mental space to review your contribution right now (200+ lines in package-lock.json). Are you cool with using your fork from now on (see my comment in the issue)? I'm sorry about that. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey, I found this project and wanted to give it a try. Currently it's all I need, and I don't have to SSH into my media station to switch the input source. Nice!
npm warned me about known vulnerabilities. It suggested a resolution by updating "express" to 4.21.
I think the changes in this pull request are all the result of
npm audit --force. I'm new to node.js and I don't know if the package-lock.json file should also be checked in..?!Using the
^4.21.0version specifier should only update to compatible versions of "express" according to https://github.com/npm/node-semver?tab=readme-ov-file#caret-ranges-123-025-004