Add action.yml
#671
Merged
Add action.yml
#671
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leighmcculloch
approved these changes
Mar 25, 2025
Member
leighmcculloch
left a comment
leighmcculloch
left a comment
There was a problem hiding this comment.
Couple suggestions inline, otherwise lgtm.
Member
|
Something we didn't do is test the action. Can you add a new workflow that tests it with its default settings across the OSes we expect it to work on, across :latest and :testing? I think that'd mean four test runs. The action tests should use the :latest and :testing that are already on dockerhub, not try to build from source local. This is because any change in actions has to work with the previous released version anyway. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds action to run quickstart in the form we usually use in our workflows.
Currently supports Linux and Mac (x84-64 only)