feat(config): expose postgres connection keepalive config options #481
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
@andrew-lee-architect could you please fix the failing tests. |
|
Nice, I've been running into this issue as well, thanks for fixing it 👍 |
Author
|
@imor I believe the tests should be passing now |
Author
|
@imor @iambriccardo thanks for running the CI--any chance I can get a review/approval on this PR? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
This PR adds the optional
keepaliveconfig option toPgConnectionConfig. This allows the user to configure and use the TCP keepalive feature on the actual postgres connection.What is the current behavior?
Currently, there is no way to configure TCP keepalives on the postgres connection.
What is the new behavior?
Now, the user can configure TCP keepalive on the postgres connection.
Additional context
The motivating use case for me is using this crate with Amazon RDS with slowly changing data. Without TCP keepalives, AWS will drop the replication connection if there isn't any activity on the line after awhile.
Hopefully this is an uncontroversial change as it just exposes some thing already available to tokio-postgres.