-
Notifications
You must be signed in to change notification settings - Fork 1.5k
docs changes #678
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
docs changes #678
Conversation
Deploying with
|
| Status | Name | Latest Commit | Preview URL | Updated (UTC) |
|---|---|---|---|---|
| ✅ Deployment successful! View logs |
supermemory-app | f9075bc | Commit Preview URL | Jan 18 2026, 04:55 AM |
Deploying with
|
| Status | Name | Latest Commit | Updated (UTC) |
|---|---|---|---|
| 🔵 In progress View logs |
supermemory-mcp | a62de97 | Jan 17 2026, 02:42 AM |
How to use the Graphite Merge QueueAdd the label Main to this PR to add it to the merge queue. You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
PR Review: Documentation & API Method RenameSummaryThis PR updates documentation across the repository and renames the API method from ✅ Positives
|
a62de97 to
98abcff
Compare
98abcff to
a6d45fa
Compare
PR Review: Documentation Changes + API StandardizationSummaryThis PR contains extensive documentation updates and standardizes the Supermemory client API usage from ✅ Code Quality & Type SafetyGood:
Python Formatting:
🔍 API Changes AnalysisChanged Pattern: // Before
await client.memories.add({ content, containerTags })
// After
await client.add({ content, containerTags })Affected Packages:
Breaking Change Assessment:
🧪 Test CoverageStatus:
📝 Documentation ChangesScope: 70+ documentation files updated in Spot Checks Recommended:
🔒 SecurityReview:
⚡ Performance
📦 Published Package ConsiderationsBreaking API Surface:
Minor Issue - Type Declarations:
✨ Recommendations
🎯 VerdictLGTM ✅ This is a clean refactor that standardizes API usage across the codebase. The code quality is good, no security issues, and the changes are consistent. The extensive documentation updates should improve developer experience. Minor note: Just verify the build succeeds and docs examples are consistent. |
PR Review: Documentation Updates and API SimplificationSummaryThis PR updates documentation extensively and simplifies the SDK API by changing ✅ Positive Changes1. API SimplificationThe API change from
2. Code Quality - PythonThe Python code quality improvements are excellent:
3. Documentation StructureSignificant improvements to documentation organization with new comprehensive guides on:
|
a6d45fa to
cd497ce
Compare
PR Review: Documentation ChangesSummaryThis PR primarily consists of documentation restructuring and reorganization in the apps/docs/ directory, with a critical API-breaking change across multiple published packages. Critical Issue: Breaking API ChangeMultiple packages have changed the API from client.memories.add() to client.add(): Affected Published Packages:
Issues:
Recommendations:
Code Quality Issues1. Python Import Reordering (packages/openai-sdk-python/)Files: middleware.py, tools.py Changes are purely cosmetic (alphabetizing imports). This follows Python conventions but adds noise to the diff. Good: Follows PEP 8 import ordering 2. Pipecat SDK Import Changes (packages/pipecat-sdk-python/)File: service.py
Documentation ChangesThe bulk of this PR is documentation reorganization:
No issues found in documentation changes - this is a positive improvement. Missing Test CoverageFor published packages (tools, ai-sdk, Python SDKs), the API change should be covered by tests. Action needed: Verify tests pass and cover the client.add() method. Security and Performance
VerdictRequest Changes This PR needs version bumps and a migration strategy before merging. The breaking API change affects multiple published packages used by external developers. Required before merge:
|
cd497ce to
d4ed531
Compare
d4ed531 to
f9075bc
Compare
PR Review: Documentation ChangesSummaryThis PR primarily contains documentation restructuring and updates, with minor API method changes across the codebase. The changes refactor the SDK API from Code Changes Review✅ Published Packages (TypeScript)packages/tools/ (
packages/ai-sdk/ (
✅ Published Packages (Python)packages/openai-sdk-python/src/supermemory_openai/middleware.py
packages/openai-sdk-python/src/supermemory_openai/tools.py
packages/pipecat-sdk-python/src/supermemory_pipecat/service.py
✅ Apps (No tests required)apps/mcp/src/client.ts
Documentation Changes ReviewBased on the file list, extensive documentation has been added/updated:
Note: Not reviewing doc content in detail as it's a large surface area and primarily prose/examples. Critical Issues🚨 Breaking API Changes Without Version Bumps All published packages have breaking changes but I don't see version bumps in:
Required Actions:
Test Coverage❌ No test changes detected for packages that have test infrastructure:
Recommendation: While the API change is straightforward (method rename), existing tests should be updated to verify:
Minor Issues✅ Code formatting (Python): Import sorting and formatting improvements are good and follow Python conventions
Verdict🔴 Recommend changes before merge
The documentation improvements look extensive and valuable, but the breaking changes need proper semver handling. |
PR Review: Documentation ChangesThis PR contains comprehensive documentation updates and an important API migration from ✅ Code Changes ReviewAPI Migration (Breaking Change for Published Packages):
Python Code Quality:
|

No description provided.