Fix string-to-number normalization for variables compared against strings #43
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ings When evaluating expressions like `device.appVersionPadded > "007.003.001"`, the string value "009.000" was incorrectly being normalized to Int(9), causing a type mismatch error. The fix: - Parse the expression first to identify variables compared against string literals - Skip string-to-number normalization for those variables - This preserves version strings like "009.000" for proper lexicographic comparison The solution checks the RHS type of comparison expressions - if a variable is compared against a string literal, its value is kept as a string even if it looks like a number. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
- Added test_version_string_comparison_not_normalized_to_number test - Added test_extract_string_compared_variables test - Fixed second normalization in device_host_properties that was bypassing the skip set The device properties were being normalized twice: 1. First pass with skip set (correct) 2. Second pass in device_host_properties without skip set (bug) 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
"009.000"were incorrectly normalized toInt(9), causing type mismatch errors when compared against string literalsdevice.appVersionPadded > "007.003.001", the padded version should remain a string for lexicographic comparisonChanges
extract_string_compared_variables()function to analyze expressions and identify variables compared against string literalsnormalize_variables_with_skip()to skip string-to-number conversion for those variablesexecute_with()and callers to pass the skip setExample
Before:
After:
Test plan
🤖 Generated with Claude Code