-
Notifications
You must be signed in to change notification settings - Fork 418
Update wireless.md #1335
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Update wireless.md #1335
Conversation
Socialhappiness
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for adding your advice and reworking the article! I've suggested a few changes. Let me know if you have any questions.
All requested edits have been completed, and the document is now ready for review. Thank you for the helpful feedback I appreciate your time and guidance!
Socialhappiness
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Needs the list formatting fixed and check consistency for using the word Wi-Fi versus WiFi or wifi since it is used differently throughout the article. Also, line 24 can be replaced with the suggested heading. Looks good!
All requested edits have been completed, and the document is now ready for review. Thank you for the helpful feedback I appreciate your time and guidance!
The requested changes have been made. I’ve fixed the list formatting, standardized the use of Wi-Fi throughout the article, and updated the heading to Initial Troubleshooting. Apologies for the oversight, and thank you for the helpful review.
|
In the future, please keep messages like "thanks for the review" in PR comments instead of the commit message, and please set the first line of the commit message to something other than the default "Update wireless.md". No need to correct the ones that are already there (this PR will get squashed when merged, anyway). |
Fixed markdownlint issues by removing trailing punctuation from headings and trimming trailing whitespace to ensure consistent formatting and pass CI checks.
|
I’ve added my documents here for review. I’d appreciate any guidance on what needs to be addressed before this can be merged. |
| @@ -1,10 +1,10 @@ | |||
| --- | |||
| title: Wireless Troubleshooting | |||
| title: Wireless and Basic Troubleshooting | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This new name doesn't make sense to me. "Basic Wireless Troubleshooting" would make more grammatical sense than "Wireless and Basic Troubleshooting." But does adding the word "basic" add any value or make this article easier for people to find?
|
|
||
| WiFi issues are influenced by many different factors, including: | ||
| If your computer can’t connect to wireless networks or the connection is unstable, use this guide to diagnose and resolve the issue. | ||
| Start with the quick checks, then follow the targeted diagnostic and recovery steps. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Having this as a line break without being a new paragraph looks weird when rendered.
I'd suggest either making it one paragraph (with no line breaks) or separate paragraphs (with a blank line in between).
Saying "start with the quick checks, then follow the targeted diagnostic and recovery steps" doesn't seem very useful when there aren't headers in the article called "quick checks" and "targeted diagnostic and recovery steps" to jump to. It's also fairly redundant with the previous sentence.
These two lines can probably be simplified to sound more natural. Something like this would be fine:
If your computer can't connect to wireless networks or the connection is unstable, the quick checks in this guide can help diagnose and fix the issue.
|
|
||
| 1.Reboot the router/modem and the computer. | ||
|
|
||
| 2.Toggle Airplane Mode by pressing **Fn + F11 →.** |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What is the →. for here? Airplane mode is Fn+F11 on many of our devices (but not all devices in general).
|
|
||
| ## Initial Troubleshooting | ||
|
|
||
| 1.Reboot the router/modem and the computer. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please put a space after the #. in ordered lists. This is currently being rendered as a series of regular paragraphs instead of a list since it's not valid Markdown for a list.
|
|
||
| 2.Toggle Airplane Mode by pressing **Fn + F11 →.** | ||
|
|
||
| 3.If your Wi-Fi issues started after an update, try removing the backported Wi-Fi driver using the command line. Open the Terminal by pressing Super+t and type the following and press Enter: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This suggestion needs to be more targeted. backport-iwlwifi-dkms is not installed by default, so it would only be present if someone installed it manually. Additionally, this package would only affect Intel wireless cards.
This is also a run-on sentence with multiple and connectors and no commas. If there are at least three steps, you need to start including commas instead (or otherwise rephrase).
|
|
||
| 2. Select your Wi-Fi connection. | ||
|
|
||
| 3. Go to IPv6 tab → change method to Ignore. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd say "the IPv6 tab" instead of just "IPv6 tab", and "the method" instead of just "method" unless you want to also capitalize that setting name.
|
|
||
| If the issues started after you applied updates, try running this command to make sure a bad WiFi driver has not been installed, then reboot your computer: | ||
| ```bash | ||
| sudo gedit /etc/modprobe.d/iwlwifi.conf |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Gedit isn't present by default anymore in Pop!_OS 24.04. We might need to consider a different way to tell people to edit configuration files.
Since this instruction is just adding a line, it can probably be done with a single Bash command.
| Another way to help with Wi-Fi issues is to turn off power management for the hardware. To do so, edit the configuration file with this command: | ||
|
|
||
| ```bash | ||
| sudo gedit /etc/NetworkManager/conf.d/default-wifi-powersave-on.conf |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Diddo on the above regarding Gedit.
| ### Windows Dual Boot | ||
|
|
||
| If you are dual booting Windows, you may lose access to your wifi card entirely after running driver/OS updates in Windows. You may be able to gain access to your wifi card again by disabling "Fast Startup" in the Windows power options before booting back into Pop!_OS. | ||
| If you are dual booting Windows, you may lose access to your Wi-Fi card entirely after running driver/OS updates in Windows. You may be able to gain access to your Wi-Fi card again by disabling "Fast Startup" in the Windows power options before booting back into Pop!_OS. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd shorten "you are" to "you're" here.
|
|
||
| ## Contact System76 Support | ||
|
|
||
| If you purchased a System76 computer and you’ve tried all the steps above, but your wireless connection still isn’t working as expected, please collect the output from the diagnostic commands and contact [System76 Support](https://system76.com/contact/support) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The last sentence needs punctuation at the end.
I'd suggest making the link include the word contact. Support probably doesn't need to be capitalized.
This update refreshes the Wireless and Basic Troubleshooting article to match the latest System76 support documentation. It has simplified commands making it easier and faster for users to resolve Wi-Fi and network issues.
I kept many of the original details while adding some of my own insights. Your feedback and thoughts on my updates would be greatly appreciated!