patch/error types #4
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Firgrep
commented
Jul 10, 2025
Firgrep
commented
- refactor: simplify footnote detection
- refactor: clippy warnings on inserters
- refactor: needless references and complex returns
- refactor: remove needless let binding
- refactor: simplify smaller transformer function returns
- refactor: use &[] instead of &Vec<_>
- refactor: use match with ordering instead of if expressions
- refactor: remove needless refrences, use contains instead of manual number range finding
- refactor: replace splitn with split
- refactor: use is_none() instead of binary comparisons
Using chars instead of strings where possible and &str instead of &String where sufficient.
? with Ok() is needless where just returning the result is fine. Remove needless references
- &[T] (slice) is more flexible than &Vec<T> - it can accept arrays, slices, and Vec references - &Vec<T> forces callers to have a Vec, while &[T] works with any contiguous collection - There's no performance difference since &Vec<T> automatically derefs to &[T] when needed
If expressions can leave unaccounted options, whereas match is stricter.
…umber range finding
splitn() is needless in this case
replace x == None with .is_none()
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.