-
-
Notifications
You must be signed in to change notification settings - Fork 129
Address tags incompatiblity introduced in 0.28.0-beta.2 #433
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
May fix #432 |
|
It needs to be backwards compatible with atleast 0.26. I'm thinking we coalesce these tags in with the API fetcher internally so that its exposed as |
|
My apologies, I should have thought of that. I've tried to make adjustments so that the UI works with beta 2 as well as prior versions, but haven't been successful. I'm stuck on the machine-row population routine throwing |
|
Let me commit to your branch, I can show you what I mean |
|
Please test this out, I can confirm it works with older versions. |
|
Thank you for the correction. I haven't run a full set of checks, but the only problem I see is that tags created in 0.27 don't appear in the UI after upgrading to 0.28-beta.1. The tags reappear after upgrading to beta.2. Tags added when running 0.28-beta.1 also don't show up on the UI, but are captured in the database. Whether it's worth investigating further is your decision. I'll try to understand your changes more thoroughly and update the other PR as well. |
|
It isn't really my intention to support beta versions anyways, so I'll ensure it works on the latest version of 0.28's beta line until the official version gets released. |
fa09964 to
696e08d
Compare
This is a set of minor changes that address the API incompatibility introduced in headscale change #2993
I may have done this wrong - I don't do much Typescript coding. However, the changes work for me.
Verified changing tags as well as general machine list operation. I did not check to see whether the tags made it into headscale.
Feel free to use or reject this change. I hope it saves you some time.