Adding Vision to robot #53
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andycate
previously approved these changes
Mar 13, 2019
| public override fun update() { | ||
|
|
||
| if (!vision.hasValidTarget) { | ||
| drivetrain.setVelocity(0.0, 0.0) |
Contributor
Author
|
Im using the same exact PID loops + math to calculate velocities in both the auto action and teleop controller. How turn this into a function somewhere. |
andycate
approved these changes
Mar 23, 2019
Member
andycate
left a comment
andycate
left a comment
There was a problem hiding this comment.
Please fix the stuff I commented on
|
|
||
| public override fun next(): Boolean { | ||
| return super.timedOut() || ( | ||
| vision.distanceToTarget < Constants.Vision.TARGET_DISTANCE // && |
Member
There was a problem hiding this comment.
Does this work? I'm concerned that this condition wont ever be satisfied
|
|
||
| public fun getStow(): Boolean | ||
|
|
||
| public fun getAutoAlign(): Boolean |
Member
There was a problem hiding this comment.
Add this function to the getState function
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.