Mod Engine 2 Fixes #24
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added additional flags to isMemoryReadable: - PAGE_EXECUTE - PAGE_EXECUTE_READ This should solve the issue of ModEngine2 failing to load the mods.
- Removed boilerplate from individual project files - Created directory-wide properties and targets - Removed debug x64 / x86 and release x86 targets - Cleaned up "post build" target to move DLLs into build folder
- Removed unused configs from solution file
- Fixed issue with props/target inclusion in project files - Fixed after-build copy target
- Included missing library in PauseTheGame
- Added starter config.ini files where needed
#2, "Clean Up Build System"
Merge updated build system.
- Restored a preprocessor definition
#1, "Fix Access Protection Constants"
- Reordered properties and targets in project config files - Added new target for generating build information
Feature #2, "Clean Up Build System"
- Updated readme file - Added example configs
- gitignore update - readme update
V1.0.0 Release Package Changes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I made some fixes based on the feedback in #15. This does not add any delays to the loading.
See release notes: https://github.com/e5h/ME2_EldenRingMods/releases/tag/V1.0.0