feat: Add 'Temporal' prefix to server startup logs for clarity #926
+5
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was changed
Updated the local server startup log messages to explicitly include the "Temporal" prefix.
Server: ...->Temporal Server: ...UI: ...->Temporal UI: ...Metrics: ...->Temporal Metrics: ...Why?
To address the ambiguity mentioned in issue #835 where users (especially in multi-service local environments) could confuse Temporal's startup logs with their own application's logs. This clarifies exactly which ports belong to the Temporal development server.
Checklist
Closes [Feature Request] Allow server startup logging to be disabled or rewritten #835
How was this tested:
Ran the server locally using
go build ./cmd/temporal && ./temporal server start-dev --headlessand verified the console output matches the new format.No.