-
Notifications
You must be signed in to change notification settings - Fork 19
Add upgrade-on-continue-as-new snippet for docs #739
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Add Go code sample demonstrating how pinned Workflows can upgrade to new Worker Deployment Versions at Continue-as-New boundaries. This snippet will be synced to the worker-versioning docs via snipsync. Source: temporalio/sdk-go@f4312424 Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The features repo is for asserting conformance across languages. It's basically a test suite. There is no assertion aspect or even use of this workflow. I wonder if samples-go would fit what you're wanting a bit more.
|
Tested using: where |
cretz
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it safe to assume this same feature will be added for other langs?
Sure at some point. I'm not sure what the urgency is here @bchav . We're working on adding upgrade on CAN to the SDKs at the moment, can this wait until then or do you want the Go snippet out ASAP once the Go SDK implementation is merged/released |
Summary
upgrade-on-continue-as-new-goContext
The worker-versioning docs (PR temporalio/documentation#4148) need a snipsync-integrated code sample for the "Upgrading on Continue-as-New" section. This snippet demonstrates how pinned Workflows can detect new Worker Deployment Versions and upgrade at Continue-as-New boundaries.
Source
Based on: temporalio/sdk-go@f431242
Files Added
features/deployment_versioning/upgrade_on_continue_as_new/feature.go- Go snippet with snipsync markersfeatures/deployment_versioning/upgrade_on_continue_as_new/README.md- DescriptionUsage in Docs
Generated with Claude Code